Skip to content

Conversation

@Carsons-Eels
Copy link
Contributor

What was wrong?

We are missing some specific exception types in master that would be useful to have there before we merge forks/osaka in during release. This set of changes are not identical to the changes in the PR it was cannibalized from, as that included adding those exception types in forks/osaka folders that do not yet exist in master.

Because we want these exception types in master now, but do not want to re-write commit history for the default branch, we are making this PR which adds all of the historical fork exception types without including code for which there is no folder yet.

⚠️ Therefore, this is a temporary addition to master, which will need to be removed before merging forks/osaka back into master during the next release. ⚠️

Related to Issue #1021

Cannibalized from PR #1286

How was it fixed?

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

Glasswing Butterfly” by Andreas Kay, CC BY-NC-SA 2.0

@Carsons-Eels Carsons-Eels changed the base branch from forks/osaka to master July 22, 2025 20:08
@Carsons-Eels Carsons-Eels changed the title Hotfix/new exception types (hotfix) New exception types Jul 22, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jul 22, 2025

Codecov Report

Attention: Patch coverage is 88.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 96.07%. Comparing base (7c4e616) to head (6d8d584).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
src/ethereum/byzantium/transactions.py 66.66% 1 Missing ⚠️
src/ethereum/constantinople/transactions.py 66.66% 1 Missing ⚠️
src/ethereum/frontier/transactions.py 66.66% 1 Missing ⚠️
src/ethereum/homestead/transactions.py 66.66% 1 Missing ⚠️
src/ethereum/spurious_dragon/transactions.py 66.66% 1 Missing ⚠️
src/ethereum/tangerine_whistle/transactions.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1342   +/-   ##
=======================================
  Coverage   96.07%   96.07%           
=======================================
  Files         534      534           
  Lines       31319    31324    +5     
  Branches     2711     2711           
=======================================
+ Hits        30090    30095    +5     
  Misses        816      816           
  Partials      413      413           
Flag Coverage Δ
unittests 96.07% <88.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@SamWilsn SamWilsn force-pushed the hotfix/new_exception_types branch from 57ae0e1 to 6d8d584 Compare July 24, 2025 13:56
@souradeep-das
Copy link
Contributor

thanks! the PR description will need an update

@SamWilsn SamWilsn merged commit 4198b9c into ethereum:master Jul 24, 2025
5 checks passed
Carsons-Eels pushed a commit to Carsons-Eels/execution-specs that referenced this pull request Oct 16, 2025
* fix(packaging): include jinja2 templates in eest package

* docs: update changelog
danceratopz added a commit to danceratopz/execution-specs that referenced this pull request Oct 22, 2025
* fix(packaging): include jinja2 templates in eest package

* docs: update changelog
@Carsons-Eels Carsons-Eels deleted the hotfix/new_exception_types branch October 31, 2025 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants