Skip to content

Conversation

spencer-tb
Copy link
Contributor

@spencer-tb spencer-tb commented Oct 6, 2025

πŸ—’οΈ Description

Follow up to #2234.

πŸ”— Related Issues or PRs

N/A.

βœ… Checklist

  • All: Ran fast tox checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:
    uvx --with=tox-uv tox -e lint,typecheck,spellcheck,markdownlint
  • All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
  • All: Considered adding an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • All: Set appropriate labels for the changes (only maintainers can apply labels).

@spencer-tb spencer-tb added scope:ci Scope: Continuous Integration type:chore Type: Chore scope:fill Scope: fill command labels Oct 6, 2025
@spencer-tb
Copy link
Contributor Author

All ELs are failing a single test in consume engine where this condition is met: https://github.com/ethereum/execution-spec-tests/blob/main/tests/osaka/eip7918_blob_reserve_price/test_blob_reserve_price_with_bpo_transitions.py#L498-L511:

test_reserve_price_at_transition[fork_OsakaToBPO1AtTime15k-at_reserve_base_fee_threshold-parent_excess_blobs_100-parent_blobs_6-blockchain_test_engine]

Still looking into it!

@marioevz
Copy link
Member

marioevz commented Oct 6, 2025

All ELs are failing a single test in consume engine where this condition is met: https://github.com/ethereum/execution-spec-tests/blob/main/tests/osaka/eip7918_blob_reserve_price/test_blob_reserve_price_with_bpo_transitions.py#L498-L511:

test_reserve_price_at_transition[fork_OsakaToBPO1AtTime15k-at_reserve_base_fee_threshold-parent_excess_blobs_100-parent_blobs_6-blockchain_test_engine]

Still looking into it!

Found the culprit, on the EELS branch, values of BLOB_SCHEDULE_MAX and BLOB_SCHEDULE_TARGET constants also have to be updated for `bpo1: https://github.com/spencer-tb/execution-specs/blob/33ecd53c4a875e0c78dc474d4400d9c2a8ccad91/src/ethereum/bpo1/vm/gas.py#L74-L75

@spencer-tb spencer-tb force-pushed the eels-bpo-testnet-changes branch from f8e21d2 to 375576b Compare October 7, 2025 10:24
@spencer-tb
Copy link
Contributor Author

Thanks! Bumped

@spencer-tb
Copy link
Contributor Author

Will update to a future EELS upstream forks/bpo once resolved with the EELS team.

@spencer-tb spencer-tb requested a review from felix314159 October 8, 2025 10:41
@spencer-tb spencer-tb merged commit 65f4ea6 into main Oct 8, 2025
15 checks passed
@spencer-tb spencer-tb deleted the eels-bpo-testnet-changes branch October 8, 2025 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope:ci Scope: Continuous Integration scope:fill Scope: fill command type:chore Type: Chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants