Skip to content

Conversation

spencer-tb
Copy link
Collaborator

@spencer-tb spencer-tb commented Jul 30, 2025

🗒️ Description

Pre-dominantly updates the compare fixtures python script we use within the coverage ci:

  • Before to remove >3000 duplicates the script would take many minutes. Now its near instant.
  • A bug is additionally resolved where all duplicates were not removed on the first pass, before it would take 3 runs to remove all duplicates (in my case testing locally). Now all duplicates are removed on the first pass.

Improved logging is added to the now "Print Unique Test IDs that will be covered" CI coverage step. This will print the test IDs of all the tests that will run for both BASE (main) and PATCH (the branch you have updated). These IDs are resolved from the compare_fixtures.py script. This will help to see if anything obvious is removed within your PR.

Prague is added back for coverage checks!

🔗 Related Issues or PRs

#1884

✅ Checklist

  • All: Ran fast tox checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:
    uvx --with=tox-uv tox -e lint,typecheck,spellcheck,markdownlint
  • All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
  • All: Considered adding an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • All: Set appropriate labels for the changes (only maintainers can apply labels).

@spencer-tb spencer-tb added scope:ci Scope: Continuous Integration type:chore Type: Chore scope:cli Scope: Changes to `ethereum_clis` labels Jul 30, 2025
@spencer-tb spencer-tb changed the title Update coverage ci chore(ci|cli): improve coverage ci and compare fixtures python script Jul 30, 2025
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! thanks for this improvement.

@marioevz marioevz merged commit e46317a into main Jul 31, 2025
15 checks passed
@marioevz marioevz deleted the update-coverage-ci branch July 31, 2025 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope:ci Scope: Continuous Integration scope:cli Scope: Changes to `ethereum_clis` type:chore Type: Chore

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants