Skip to content

Conversation

@spencer-tb
Copy link
Collaborator

@spencer-tb spencer-tb commented Jul 10, 2025

🗒️ Description

This PR makes the blob tx wrapper version fork agnostic. PeerDAS introduced the wrapper version field where:

< Osaka: rlp([tx_payload_body, blobs, commitments, proofs])
>= Osaka: rlp([tx_payload_body, wrapper_version,  blobs, commitments, cell_proofs])

Following the latter we have updated the existing PeerDAS get blobs tests to use the fork agnostic wrapper version. It additionally fixes the filling of test_blob_full_txs.py tests for Osaka by introducing this field.

Assuming the version updates again in the future we will only need to add a new fork method with the new version.

🔗 Related Issues or PRs

Blocker for #1884.

✅ Checklist

  • All: Ran fast tox checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:
    uvx --with=tox-uv tox -e lint,typecheck,spellcheck,markdownlint
  • All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
  • All: Considered adding an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • All: Set appropriate labels for the changes (only maintainers can apply labels).

@spencer-tb spencer-tb added scope:tests Scope: Changes EL client test cases in `./tests` type:chore Type: Chore fork:osaka Osaka hardfork labels Jul 10, 2025
Copy link
Collaborator

@fselmo fselmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👌🏼

@marioevz marioevz merged commit 8f516ce into main Jul 10, 2025
14 checks passed
@marioevz marioevz deleted the fix-blob-tx-wrapper-version branch July 10, 2025 21:16
kclowes pushed a commit to kclowes/execution-spec-tests that referenced this pull request Oct 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fork:osaka Osaka hardfork scope:tests Scope: Changes EL client test cases in `./tests` type:chore Type: Chore

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants