-
Notifications
You must be signed in to change notification settings - Fork 178
feat(cli): resolve updated execution_spec exceptions #1784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Sorry! I completely missed this. Looking now :) |
Okay great! This already caught some issues. Would it be possible to rebase this PR onto main? It might be easier to drop the other commits, to start fresh and add a single commit with just the eels exception changes. Then force push etc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a couple small comments!
Ohh and can we add this:
TransactionException.GAS_LIMIT_EXCEEDS_MAXIMUM: "TransactionGasLimitExceededError",
5344bcd
to
a14a713
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
🗒️ Description
Specific exceptions were added to execution_spec
InvalidTransaction
types. This is a complementary update to accommodate for these specific exceptions.Exception types and details are outlined here:
🔗 Related Issues
ethereum/execution-specs#1021
✅ Checklist