Skip to content

Conversation

souradeep-das
Copy link
Contributor

@souradeep-das souradeep-das commented Jun 23, 2025

🗒️ Description

Specific exceptions were added to execution_spec InvalidTransaction types. This is a complementary update to accommodate for these specific exceptions.

Exception types and details are outlined here:

🔗 Related Issues

ethereum/execution-specs#1021

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.

@spencer-tb spencer-tb added type:feat type: Feature scope:cli Scope: Changes to `ethereum_clis` labels Jun 25, 2025
@spencer-tb spencer-tb changed the title feat: resolve updated execution_spec exceptions feat(cli): resolve updated execution_spec exceptions Jun 25, 2025
@souradeep-das souradeep-das marked this pull request as ready for review July 17, 2025 14:08
@spencer-tb
Copy link
Contributor

Sorry! I completely missed this. Looking now :)

@spencer-tb
Copy link
Contributor

Okay great! This already caught some issues. Would it be possible to rebase this PR onto main?
So it only contains the exceptions changes (no eels resolutions changes)

It might be easier to drop the other commits, to start fresh and add a single commit with just the eels exception changes. Then force push etc.

Copy link
Contributor

@spencer-tb spencer-tb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a couple small comments!

Ohh and can we add this:

TransactionException.GAS_LIMIT_EXCEEDS_MAXIMUM: "TransactionGasLimitExceededError",

@souradeep-das souradeep-das force-pushed the souradeep/custom_exc branch from 5344bcd to a14a713 Compare July 29, 2025 09:49
Copy link
Contributor

@spencer-tb spencer-tb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope:cli Scope: Changes to `ethereum_clis` type:feat type: Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants