Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new(tests): add state test with empty 7702 authorization list #1224

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

new(tests): add state test with empty 7702 authorization list #1224

wants to merge 1 commit into from

Conversation

chfast
Copy link
Member

@chfast chfast commented Feb 17, 2025 •
edited
Loading

🗒️ Description

🔗 Related Issues

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: A PR with removal of converted JSON/YML tests from ethereum/tests have been opened.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@chfast chfast force-pushed the empty_authorization_list branch from 64014f5 to eb801b7 Compare February 17, 2025 09:48
@chfast chfast added the scope:tests Scope: Changes EL client test cases in `./tests` label Feb 17, 2025
@chfast chfast requested a review from marioevz February 17, 2025 11:04
marioevz
marioevz reviewed Feb 17, 2025
View reviewed changes
tests/prague/eip7702_set_code_tx/test_set_code_txs.py
gas_limit=100_000,
to=pre.deploy_contract(code=b""),
value=0,
authorization_list=[],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I vaguely remember @lightclient mentioning that this test would fail on the tx decoding part, which leads to failure of the state test. Tagging him to help us out on whether including this test would pose an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marioevz marioevz marioevz left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
scope:tests Scope: Changes EL client test cases in `./tests`
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chfast @marioevz