Merge pull request #671 from ethereum/ci

ci: Upgrade and clean up builds, add macOS
ethereum · Aug 24, 2022 · b682b5a · b682b5a
2 parents 184b08a + 9855bc7
commit b682b5a
Show file tree

Hide file tree

Showing 3 changed files with 28 additions and 10 deletions.
diff --git a/circle.yml b/circle.yml
@@ -6,10 +6,10 @@ orbs:
 executors:
   linux-gcc-latest:
     docker:
-      - image: ethereum/cpp-build-env:17-gcc-11
+      - image: ethereum/cpp-build-env:18-gcc-12
   linux-clang-latest:
     docker:
-      - image: ethereum/cpp-build-env:17-clang-13
+      - image: ethereum/cpp-build-env:18-clang-14
 
 
 commands:
@@ -271,7 +271,7 @@ jobs:
 
   build-gcc-32bit:
     docker:
-      - image: ethereum/cpp-build-env:14-gcc-10-multilib
+      - image: ethereum/cpp-build-env:17-gcc-11-multilib
     steps:
       - checkout
       - build:
@@ -280,7 +280,7 @@ jobs:
 
   build-cmake-min:
     docker:
-      - image: circleci/buildpack-deps:bionic
+      - image: cimg/base:stable-18.04
     steps:
       - run:
           name: "Install default CMake"
@@ -289,9 +289,20 @@ jobs:
       - build
       - test
 
+  build-macos:
+    macos:
+      xcode: 14.0.0
+    steps:
+      - run:
+          name: "Install System Dependencies"
+          command: HOMEBREW_NO_AUTO_UPDATE=1 brew install cmake
+      - checkout
+      - build
+      - test
+
   bindings-go-latest:
     docker:
-      - image: circleci/golang
+      - image: cimg/go:1.19
     steps:
       - go_test
 
@@ -411,6 +422,7 @@ workflows:
       - build-clang-min
       - build-gcc-32bit
       - build-cmake-min
+      - build-macos
       - bindings-go-latest:
           filters:
             tags:

diff --git a/test/unittests/cpp_test.cpp b/test/unittests/cpp_test.cpp
@@ -829,7 +829,10 @@ TEST(cpp, status_code_to_string)
 
 // NOLINTNEXTLINE(cppcoreguidelines-macro-usage)
 #define TEST_CASE(NAME) \
-    TestCase { NAME, #NAME }
+    TestCase            \
+    {                   \
+        NAME, #NAME     \
+    }
     constexpr TestCase test_cases[]{
         TEST_CASE(EVMC_SUCCESS),
         TEST_CASE(EVMC_FAILURE),
@@ -880,7 +883,10 @@ TEST(cpp, revision_to_string)
 
 // NOLINTNEXTLINE(cppcoreguidelines-macro-usage)
 #define TEST_CASE(NAME) \
-    TestCase { NAME, #NAME }
+    TestCase            \
+    {                   \
+        NAME, #NAME     \
+    }
     constexpr TestCase test_cases[]{
         TEST_CASE(EVMC_FRONTIER),
         TEST_CASE(EVMC_HOMESTEAD),
@@ -928,13 +934,13 @@ TEST(cpp, revision_to_string)
 }
 
 
-#ifdef __GNUC__
+#if defined(__GNUC__) && !defined(__APPLE__)
 extern "C" [[gnu::weak]] void __ubsan_handle_builtin_unreachable(void*);  // NOLINT
 #endif
 
 static bool has_ubsan() noexcept
 {
-#ifdef __GNUC__
+#if defined(__GNUC__) && !defined(__APPLE__)
     return (__ubsan_handle_builtin_unreachable != nullptr);
 #else
     return false;

diff --git a/test/vmtester/CMakeLists.txt b/test/vmtester/CMakeLists.txt
@@ -13,7 +13,7 @@ add_test(NAME ${prefix}/help COMMAND evmc::evmc-vmtester --version --help)
 set_tests_properties(${prefix}/help PROPERTIES PASS_REGULAR_EXPRESSION "Usage:")
 
 add_test(NAME ${prefix}/nonexistingvm COMMAND evmc::evmc-vmtester nonexistingvm)
-set_tests_properties(${prefix}/nonexistingvm PROPERTIES PASS_REGULAR_EXPRESSION "[Cc]annot open")
+set_tests_properties(${prefix}/nonexistingvm PROPERTIES PASS_REGULAR_EXPRESSION "[Cc]annot open|no such file")
 
 add_test(NAME ${prefix}/noarg COMMAND evmc::evmc-vmtester)
 set_tests_properties(${prefix}/noarg PROPERTIES PASS_REGULAR_EXPRESSION "is required")