Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shadcn Migrate: Migrate acknowledgements page to Shadcn #14693

Merged
merged 4 commits into from
Jan 17, 2025
Merged

Shadcn Migrate: Migrate acknowledgements page to Shadcn #14693

merged 4 commits into from
Jan 17, 2025

Conversation

JoeChenJ
Copy link
Contributor

Description

Migrate acknowledgements page to Shadcn

Related Issue

#13946

@netlify Netlify
Copy link

netlify bot commented Jan 16, 2025 •
edited
Loading

✅ Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 2a61bb6
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/678a6c0ef150d80008228bf8
😎 Deploy Preview https://deploy-preview-14693--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 7 paths audited
Performance: 48 (no change from production)
Accessibility: 92 (no change from production)
Best Practices: 89 (🔴 down 9 from production)
SEO: 98 (no change from production)
PWA: 59 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@pettinarip pettinarip mentioned this pull request Jan 16, 2025
Open
41 tasks
pettinarip
pettinarip approved these changes Jan 17, 2025
View reviewed changes
Copy link
Member

@pettinarip pettinarip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pettinarip pettinarip merged commit 4051a0b into ethereum:dev Jan 17, 2025
10 checks passed
@JoeChenJ JoeChenJ deleted the Migrate_acknowledgements_to_shadcn branch January 17, 2025 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pettinarip pettinarip pettinarip approved these changes

@wackerow wackerow Awaiting requested review from wackerow wackerow is a code owner

@corwintines corwintines Awaiting requested review from corwintines corwintines is a code owner

@minimalsm minimalsm Awaiting requested review from minimalsm minimalsm is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JoeChenJ @pettinarip