ethash: fix undefined Sha3Hash function
#119
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `Sha3Hash` function was removed from go-ethereum in the 1.6.x series: commit 72dd51e25a5c1553a5a7fc5f0fb84fbe3546682f Author: Péter Szilágyi <[email protected]> Date: Thu Jun 1 10:24:40 2017 +0300 Now we can just call `crypto.Keccak256Hash` directly.
exitstop
approved these changes
Sep 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Sha3Hashfunction was removed from go-ethereum in the 1.6.x series:commit 72dd51e25a5c1553a5a7fc5f0fb84fbe3546682f
Author: Péter Szilágyi [email protected]
Date: Thu Jun 1 10:24:40 2017 +0300
Now we can just call
crypto.Keccak256Hashdirectly.This unblocks the ability to build a dApp using the latest go-ethereum in golang, without encountering duplicated symbol errors. Please merge.