Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

misc fixes from cpp-ethereum repo. #110

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

misc fixes from cpp-ethereum repo. #110

wants to merge 7 commits into from

Commits on Nov 22, 2018

  1. Critical Section __m512i union 

    This improves performance using 512bit SIMD instructions.
    @hackmod
    mancoast authored and hackmod committed Nov 22, 2018
    Configuration menu
    Copy the full SHA
    90826b1 View commit details
    Browse the repository at this point in the history

  2. Resolve GCC 7+ warnings 

    Fixes #4115.
    @Dar13 @hackmod
    Dar13 authored and hackmod committed Nov 22, 2018
    Configuration menu
    Copy the full SHA
    0e2f2ec View commit details
    Browse the repository at this point in the history

  3. Use 64-bit seek functions instead of fseek when generating DAG file

    @gumb0 @hackmod
    gumb0 authored and hackmod committed Nov 22, 2018
    Configuration menu
    Copy the full SHA
    2e05a27 View commit details
    Browse the repository at this point in the history

  4. Added warning suppression using pragmas for Debian. 

    It looks like older versions of GCC have slightly unreliable logic for array out-of-bounds detection.
Code in ethash which uses unions and arrays is firing a warning in both Debian Jesse (8.5) and in the ARM Linux cross-builds.
Debian Jesse uses GCC 4.9.2.   The cross-builds are using GCC 4.8.4.
Other distros are using GCC 5.x or even GCC 6.x (Arch).
The issue is https://gcc.gnu.org/bugzilla/show_bug.cgi?id=56273 and was fixed in GCC 5.0 and backported to 4.9.3.

Updated comments.
    @bobsummerwill @hackmod
    bobsummerwill authored and hackmod committed Nov 22, 2018
    Configuration menu
    Copy the full SHA
    7310406 View commit details
    Browse the repository at this point in the history

  5. Fix GCC warning - 'static' is not at beginning of declaration. 

    With this change we will be able to remove a global warning suppression from our CMake files.
    @bobsummerwill @hackmod
    bobsummerwill authored and hackmod committed Nov 22, 2018
    Configuration menu
    Copy the full SHA
    31fbca2 View commit details
    Browse the repository at this point in the history

  6. libethash: avoid passing nullptr to strlen

    @pirapira @hackmod
    pirapira authored and hackmod committed Nov 22, 2018
    Configuration menu
    Copy the full SHA
    03d18d6 View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2018

  1. add a missing blockNum parameter

    @hackmod
    hackmod committed Nov 25, 2018
    Configuration menu
    Copy the full SHA
    04efce1 View commit details
    Browse the repository at this point in the history