Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass max_blobs_per_block into Engine API methods #4042

Closed

Conversation

jtraglia
Copy link
Member

@jtraglia jtraglia commented Dec 6, 2024

Discussed on Discord here. We might need to pass max_blobs_per_block (not just target_blobs_per_block) to the EL. Without it, the EL is unable to do certain tasks (eg eth_feeHistory) due to a lack of information. This is a follow up to:

@jtraglia jtraglia mentioned this pull request Dec 6, 2024
13 tasks
Copy link
Contributor

@g11tech g11tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i guess this is sort of needed as many other places EL tends to use the current max (to not get DOS-ed by the tx, to prune the versioned hashes to blob map)

lgtm

@jtraglia
Copy link
Member Author

An update from client testing call 16:

Pass max_blobs_per_block into Engine API methods 1: Decided to include it in a future devnet to give us more time for consensus, so it would not be included in the latest release

So we are going to wait to merge this PR until we've decided what the right approach is.

@jtraglia
Copy link
Member Author

Closing in favor of #4046.

@jtraglia jtraglia closed this Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants