-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validator identities endpoint. #452
base: master
Are you sure you want to change the base?
Conversation
In support of ethereum#449.
This looks good. Will cross-post and seek more opinions. |
pubkey: | ||
$ref: './primitive.yaml#/Pubkey' | ||
description: "Public key of validator." | ||
activation_epoch: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why add the activation_epoch
? It's a curious in-between of no epoch and all epochs in the validator record
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's in case validator index reuse comes in, it will allow us to use (index,public key, activation epoch) as a unique identifier for a validator across all time regardless of reuse.
I support this. Our validator client currently needs to grab the full validator to get the index |
Curious, do you track the validator status on the VC side? This has a lot of benefits, e.g. not querying duties for exited validators, not registering to builder etc. but it would still require to query the full validator object if we don't include all information in this API to recalculate the status, or include the status itself here, preferably in a format that can be ssz-serialized. |
No, we don't. I agree it would allow for certain optimizations, but I am not sure if it's worth the extra complexity. |
I think i prefer the idea that this is a simple index lookup that would allow us to continue to use it in a post index being unique world, and for the rest of the data you have the indices you could look up further info... |
we can definitely add this to changes table though... |
In support of #449.