-
Notifications
You must be signed in to change notification settings - Fork 44
Renaming and refactorinng in the ASTs and typing #198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in postconditions; some small fixes in generated bounds
lefterislazar
approved these changes
Jul 16, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a mix of typo corrections and aesthetic modifications, some may be worth committing.
Co-authored-by: lefterislazar <[email protected]>
Co-authored-by: lefterislazar <[email protected]>
Co-authored-by: lefterislazar <[email protected]>
Co-authored-by: lefterislazar <[email protected]>
Co-authored-by: lefterislazar <[email protected]>
Co-authored-by: lefterislazar <[email protected]>
Co-authored-by: lefterislazar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the Act AST and typing pass to improve clarity and maintainability.
File name changes
Change name of
TimeAgnostic.hs
toTyped.hs
Rationale: This file defines the core typed AST. Expressions may be either implicitly or explicitly timed,
Change name of
Typed.hs
toTypedImplicit.hs
Rationale: Represents the typed AST where timing annotations are may still be implicit in some places.
Change name of
Annotated.hs
toTypedExplicit.hs
Rationale: Represents the typed AST with all timing annotations made explicit.
Change name of
Enrich.hs
toBounds.hs
Rationale: This file implements a pass that adds integer bounds (derived from types) as preconditions and postconditions for calldata, storage, and environment variables. The new name better reflects its purpose.
Renaming of AST nodes
Renamed several AST nodes to better reflect their purpose:
Untyped AST (
Untyped.hs
):Definition
→Constructor
Defn
→Mapping
AssignMany
→AssignMapping
Typed AST (
Typed.hs
):TEntry
→VarRef
InavariantPred
to get rid of type familiesCode refactoring
Refactored the code in
Type.hs
so that it does proper type inference instead of trying to type an expression with all possible types in order to infer its type. This lead to more efficient code and better error messages.defaultStore
renamed toglobalEnv
inType.hs
Miscellaneous