Update ERC-7796: Update erc-7796.md #1032
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ All reviewers have approved. |
forshtat
reviewed
May 7, 2025
| @@ -65,13 +65,16 @@ it is CPU-intensive to find an optimal ordering of transactions. | |||
| * **timestampMax**: maximum block timestamp for inclusion. | |||
| * **paysCoinbase**: the caller declares the minimum amount paid to the `coinbase` by this transaction, | |||
| including gas fees and direct payment. | |||
| * All numeric values should use hex string notation. | |||
There was a problem hiding this comment.
Suggested change
| * All numeric values should use hex string notation. | |
| * All numeric values MUST use hex string notation. |
| @@ -50,7 +50,7 @@ it is CPU-intensive to find an optimal ordering of transactions. | |||
| * The `options` parameter may include any of the following optional members: | |||
| * **knownAccounts**: a mapping of accounts with their expected storage slots' values. | |||
| * The key of the mapping is account address. | |||
| * A special key `balance` defines the expected balance of the account. | |||
| * A special key `balance` defines the expected balance of the account. The balance is expected to be at least this value. | |||
There was a problem hiding this comment.
Suggested change
| * A special key `balance` defines the expected balance of the account. The balance is expected to be at least this value. | |
| * A special key `balance` defines the expected balance of the account. The balance MUST be at least this value. |
| @@ -105,10 +108,11 @@ the caller MUST NOT assume that a transaction will be included in a block and sh | |||
| { | |||
| "blockNumberMax": 12345, | |||
| "knownAccounts": { | |||
| "0xadd1": "0xfedc....", | |||
| "0xadd1": "0xfedc....", // | |||
There was a problem hiding this comment.
Suggested change
| "0xadd1": "0xfedc....", // | |
| "0xadd1": "0xfedc....", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.