Skip to content

Conversation

MozirDmitriy
Copy link
Contributor

  • Problem: The spec incorrectly required validating systemLogsRoot during engine_forkchoiceUpdated. Engine API payload field validations (e.g., receiptsRoot, withdrawals_root) occur at payload acceptance in engine_newPayloadVx, not during fork choice updates.
  • Change: Moved the validation requirement to engine_newPayloadVx and specified rejection of invalid payloads (e.g., INVALID).
  • Impact: Aligns with established Engine API semantics, prevents transient acceptance of invalid payloads, and matches how clients validate new payloads.

@MozirDmitriy MozirDmitriy requested a review from eth-bot as a code owner October 13, 2025 14:43
@github-actions github-actions bot added c-update Modifies an existing proposal s-draft This EIP is a Draft t-core labels Oct 13, 2025
@eth-bot
Copy link
Collaborator

eth-bot commented Oct 13, 2025

File EIPS/eip-7799.md

Requires 1 more reviewers from @etan-status, @g11tech

@eth-bot eth-bot added the a-review Waiting on author to review label Oct 13, 2025
@etan-status
Copy link
Contributor

engine_newPayload does not necessarily trigger processing (e.g., ACCEPTED result, if a block gets imported from a different branch). Such processing is delayed until engine_forkchoiceUpdated.

engine_newPayload only does minimal validation to guarantee that the block hash matches the content (otherwise, one could disconnect them and build on top of an invalid chain or even create loops).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a-review Waiting on author to review c-update Modifies an existing proposal s-draft This EIP is a Draft t-core

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants