Fix SWS typo in glossary.md #267
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Was stating that the default Sequencer Window Size was measured in "epochs" instead of blocks
miltonjonat
requested review from
ajsutton,
mslipper,
protolambda,
sebastianst and
tynes
as code owners
ajsutton
reviewed
Jul 22, 2024
| `N`. The window contains blocks `[N, N + SWS)` where `SWS` is the sequencer window size. | ||
|
|
||
| The current default `sws` is 3600 epochs. | ||
| The current default `sws` is 3600 blocks. |
There was a problem hiding this comment.
We probably should be explicit that these are L1 blocks. The original epochs, while being a rather circular reference, is more accurate than just "blocks" because each L1 block is an epoch (but an epoch may contain multiple L2 blocks). It's already strongly implied by the context but people often get confused about whether "blocks" means L1 or L2 blocks so best to be clear.
|
need any help here addressing review @miltonjonat ? |
emhane
added
S-stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Glossary was stating that the default Sequencer Window Size was measured in "epochs" instead of blocks
Tests
N/A
Additional context
N/A
Metadata
N/A