fix: Handle RPC connection error properly #517
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is not part of the op-stack functionality, just an example-test. And there's no error handling precisely because it's an example. Please do not submit more AI-generated PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed an issue where the RPC connection error was ignored, which could lead to a panic if the connection failed. Now, the error is properly handled by logging a message and safely exiting.
Tests
Manually tested by attempting to connect to an invalid WebSocket URL and verifying that the error is logged instead of causing a panic.
Additional context
Ignoring connection errors can lead to unexpected crashes, especially in environments where network stability is not guaranteed. This change ensures that failures are handled gracefully.
Metadata