feat: ensure no requests are included in isthmus blocks #498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refcell
approved these changes
Feb 12, 2025
sebastianst
reviewed
Feb 12, 2025
sebastianst
approved these changes
Feb 12, 2025
…9/op-geth into meyer9/ensure-requests-array-empty
|
Fixed a test which was broken if Isthmus was enabled but Cancun isn't. |
|
Yeah because after Isthmus requests is always an empty array, whereas prior to this change, requests was nil for the test that was modified (broke because the previous RLP item was nil). |
|
Awesome stuff 🚀 |
sebastianst
pushed a commit
that referenced
this pull request
Feb 26, 2025
* feat: ensure no requests are included in isthmus blocks * Ensure cancun enabled in block encode decode test --------- Co-authored-by: refcell <[email protected]>
sebastianst
pushed a commit
that referenced
this pull request
Feb 26, 2025
* feat: ensure no requests are included in isthmus blocks * Ensure cancun enabled in block encode decode test --------- Co-authored-by: refcell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures requests array is empty post-Isthmus, but still runs normal processing events for these contracts (just ignores the requests).