node: Enable miner rpc in authrpc if enabled in http #491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
protolambda
reviewed
Feb 5, 2025
protolambda
approved these changes
Feb 7, 2025
protolambda
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables the
minerRPC module on the AuthRPC endpoint when it's enabled for HTTP (--http.modules miner). This aligns with op-reth's approach.This PR does not add any additional security exposure as AuthRPC endpoint has stricter access controls than HTTP.
A simpler alternative would be to enable this by default in DefaultAuthRpc. Let me know which approach you prefer.
Tests
Let me know if want me to add a test on
node_test.go.Additional context
This change is needed for Rollup-boost. Rollup-boost uses the AuthRPC endpoint to communicate with builders, so having the miner module enabled there simplifies its implementation.
Metadata