Skip to content

Add metric that monitors fallback candidate health #417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dpulitano wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add metric that monitors fallback candidate health #417

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
07fa04d
add fallback metric
dpulitano Jun 25, 2025
c641ffc
always monitor fallback candidate health
dpulitano Jun 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions proxyd/consensus_poller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -732,13 +732,16 @@ func (cp *ConsensusPoller) setBackendState(be *Backend, peerCount uint64, inSync
func (cp *ConsensusPoller) getConsensusCandidates() map[*Backend]*backendState {

healthyPrimaries := cp.FilterCandidates(cp.backendGroup.Primaries())

RecordHealthyCandidates(cp.backendGroup, len(healthyPrimaries))

healthyFallbacks := cp.FilterCandidates(cp.backendGroup.Fallbacks())
RecordHealthyFallbackCandidates(cp.backendGroup, len(healthyFallbacks))

if len(healthyPrimaries) > 0 {
return healthyPrimaries
}

return cp.FilterCandidates(cp.backendGroup.Fallbacks())
return healthyFallbacks
}

// filterCandidates find out what backends are the candidates to be in the consensus group
Expand Down
12 changes: 12 additions & 0 deletions proxyd/metrics.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -442,6 +442,14 @@ var (
"backend_group_name",
})

healthyFallbackCandidates = promauto.NewGaugeVec(prometheus.GaugeOpts{
Namespace: MetricsNamespace,
Name: "healthy_fallback_candidates",
Help: "Record the number of healthy fallback candidates",
}, []string{
"backend_group_name",
})

backendGroupFallbackBackend = promauto.NewGaugeVec(prometheus.GaugeOpts{
Namespace: MetricsNamespace,
Name: "backend_group_fallback_backenend",
Expand Down Expand Up @@ -605,6 +613,10 @@ func RecordHealthyCandidates(b *BackendGroup, candidates int) {
healthyPrimaryCandidates.WithLabelValues(b.Name).Set(float64(candidates))
}

func RecordHealthyFallbackCandidates(b *BackendGroup, candidates int) {
healthyFallbackCandidates.WithLabelValues(b.Name).Set(float64(candidates))
}

func RecordConsensusBackendPeerCount(b *Backend, peerCount uint64) {
consensusPeerCountBackend.WithLabelValues(b.Name).Set(float64(peerCount))
}
Expand Down