Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reintroduce SlaveClient, size-optimise EEPROM #100

Merged
merged 3 commits into from
Aug 17, 2023
Merged

Reintroduce SlaveClient, size-optimise EEPROM #100

merged 3 commits into from
Aug 17, 2023

Conversation

jamwaffles
Copy link
Collaborator

Split SlaveClient from SlaveRef. This removes a generic, so code size is reduced from less monomorphisation.

Also some EEPROM code size optimisations.

master

   text    data     bss     dec     hex filename
  96012     112   50560  146684   23cfc ethercrab-stm32-embassy

This PR

   text    data     bss     dec     hex filename
  90604     112   50560  141276   227dc ethercrab-stm32-embassy

@jamwaffles jamwaffles enabled auto-merge (squash) August 17, 2023 21:13
@jamwaffles jamwaffles merged commit 13ea425 into master Aug 17, 2023
3 checks passed
@jamwaffles jamwaffles deleted the slave-client-again branch August 17, 2023 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jamwaffles