Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker: Add ability to specify configuration file as a build arg #5944

Merged
merged 1 commit into from
Sep 23, 2023
Merged

Docker: Add ability to specify configuration file as a build arg #5944

merged 1 commit into from
Sep 23, 2023

Conversation

dhalenok
Copy link
Contributor

@dhalenok dhalenok commented Sep 22, 2023

This PR adds ability to specify configuration file as a docker build argument for custom build.

Usage example:

docker build --build-arg SETTINGS=./settings.json.docker.development .

This is useful when there's a need to have different configuration files, for example to specify plugin settings for different environments.

@SamTV12345
Copy link
Member

Thanks. Great idea to make the docker build more flexible.

@SamTV12345 SamTV12345 merged commit 53ef77a into ether:develop Sep 23, 2023
20 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants