Updated device handler and LUM #140
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added working logic for the pin length. Should be able to correctly set a lock pin length now.
Incorporated fix from djanosChef to resolve manual unlock notifications. ethayer#120 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This incorporates some fixes to the device handler including the terminology and defaults used in the Schlage documentation. I was having troubles setting the pin length due to is using an integer to set the pin length vs the proper value (0x04 - 0x08). I updated this but there is likely a cleaner and more efficient way to do so.
The LUM was updated with code to fix the manual updates notification. Seems pretty rock solid now.