Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: move help files to project root #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cmsax
Copy link

@cmsax cmsax commented Sep 25, 2020

Re-arrange help files like:

  • LICENSE
  • README.md
  • WHATSNEW

to project root directory.

pip install . test passed with python2.7 & python3.7.7.

@cmsax
Copy link
Author

cmsax commented Sep 25, 2020

This PR is a patch for Issue #5

@cmsax
Copy link
Author

cmsax commented Sep 25, 2020

Python2.7 pip install . result:

image

Python 3.7.7 pip install . result:

image

@wagnerpeer
Copy link

You deleted the MANIFEST?
Maybe it should be altered in the following way:

recursive-include dbf *
LICENSE
README.md
setup.py
WHATSNEW

@cmsax
Copy link
Author

cmsax commented Oct 16, 2020

You deleted the MANIFEST?
Maybe it should be altered in the following way:

recursive-include dbf *
LICENSE
README.md
setup.py
WHATSNEW

Thanks, I'll try.

Copy link
Owner

@ethanfurman ethanfurman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your interest! When making changes, change as little as possible. If you want to update your PR for the latest code base, I'll be happy to accept it.

Comment on lines -1 to -6
try:
import setuptools
setuptools
except ImportError:
pass
from distutils.core import setup
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not be changed.

Comment on lines -22 to -60
data = dict(
name='dbf',
version='0.99.1a1',
license='BSD License',
description='Pure python package for reading/writing dBase, FoxPro, and Visual FoxPro .dbf files (including memos)',
long_description=long_desc,
url='https://github.com/ethanfurman/dbf',
packages=['dbf', ],
package_data={
'dbf' : [
'LICENSE',
'README.md',
'WHATSNEW',
]
},
provides=['dbf'],
install_requires=['aenum'],
author='Ethan Furman',
author_email='[email protected]',
classifiers=[
'Development Status :: 4 - Beta',
'Intended Audience :: Developers',
'License :: OSI Approved :: BSD License',
'Programming Language :: Python',
'Topic :: Database',
'Programming Language :: Python :: 2.7',
'Programming Language :: Python :: 3.3',
'Programming Language :: Python :: 3.4',
'Programming Language :: Python :: 3.5',
'Programming Language :: Python :: 3.6',
'Programming Language :: Python :: 3.7',
'Programming Language :: Python :: 3.8',
'Programming Language :: Python :: 3.9',
],
)

if __name__ == '__main__':
setup(**data)

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This style needs to be maintained.

Comment on lines -1 to -5
setup.py
dbf/__init__.py
dbf/tests.py
dbf/WHATSNEW
dbf/README.md
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Undelete this file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants