RFC attempt to fix #744

[sorokin]

This is more like a request for comments than a real pull request.

Basically what I did is I passed QMenu* parent to all plugin functions that create menus. Full description is in the commit message.

What do you think?

[eteran]

The idea of threading the main window's pointer to the plugin so it can be set as the parent seems reasonable at first blush, I've been pretty busy at work, but I'll try to take a closer look asap.

[sorokin]

Thank you for the response.

I've been pretty busy at work, but I'll try to take a closer look asap.

That's totally fine. I don't mind if the PR is reviewed later and is reviewed better. There is no rush in doing this at all. Take your time. Thanks!

[eteran]

I started to look at this PR, as I said, threading the parent to the plugins seems like a generally good solution. Though I'm unsure about the globalShortcuts concept. I see what you're going for with it, but it kinda makes sense that shortcuts which happen to have a shortcut will "just work" and not need to be part of a separate list that could be forgotten to get updated.

[sorokin]

Though I'm unsure about the globalShortcuts concept.

That's why I'm not sure about it either. But I don't know better solution. The problem I had was the following. Conceptually there are 2 types of actions: ones that are created at plugin initialization time and they live while the plugin is loaded, others that are created when menu is invoked and are destroyed when menu is dismissed. For action to have a global shortcut it must be of the first type. Unfortunately the previous interface doesn't allow getting only these global actions. That's why I invented this globalShortcuts function.

Let me know if you have any other ideas. As I said I'm not sure about the concept, but I don't have any better ideas.

[eteran]

I'll think about it, and see if we can come up with a better solution. 👍

[sorokin]

I updated the PR by removing unneeded usage of std::cerr that I used for debug.

diff --git a/src/Debugger.cpp b/src/Debugger.cpp
index e3590e70..0acb725e 100644
--- a/src/Debugger.cpp
+++ b/src/Debugger.cpp
@@ -863,7 +863,6 @@ void Debugger::finishPluginSetup() {
                        for (QAction *action : actions) {
                                QKeySequence shortcut = action->shortcut();
                                if (!shortcut.isEmpty()) {
-                                       std::cerr << shortcut.toString().toUtf8().constData() << std::endl;
                                        connect(new QShortcut(shortcut, this), &QShortcut::activated, action, &QAction::trigger);
                                }
                        }

[eteran]

@sorokin as you can imagine, it's been a hectic and sometimes very unproductive year. But I'm getting back into a groove and plan to work on this issue in the near future!

Thanks for your contribution :-).