-
Notifications
You must be signed in to change notification settings - Fork 10.3k
Add range test cases by value #21255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted filessee 20 files with indirect coverage changes @@ Coverage Diff @@
## main #21255 +/- ##
==========================================
+ Coverage 68.41% 68.43% +0.02%
==========================================
Files 428 428
Lines 35256 35256
==========================================
+ Hits 24119 24129 +10
+ Misses 9740 9731 -9
+ Partials 1397 1396 -1 Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
c4dc349 to
cd623ae
Compare
cd623ae to
febc06c
Compare
febc06c to
81cc8f7
Compare
Signed-off-by: Nont <[email protected]>
81cc8f7 to
a81c31b
Compare
|
/retest |
|
@serathius ready for your review now. This modifies the test data by shuffling the values, adds new slices for sort by values, and adds new sort by value test cases (plus modifies the existing one that does a sort by value). |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nwnt, serathius The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Splitting #21246 by adding sorted by values cases only.
@serathius