Skip to content

Conversation

@nwnt
Copy link
Member

@nwnt nwnt commented Feb 6, 2026

Splitting #21246 by adding sorted by values cases only.

@serathius

@codecov
Copy link

codecov bot commented Feb 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.43%. Comparing base (8f1c499) to head (a81c31b).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

see 20 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #21255      +/-   ##
==========================================
+ Coverage   68.41%   68.43%   +0.02%     
==========================================
  Files         428      428              
  Lines       35256    35256              
==========================================
+ Hits        24119    24129      +10     
+ Misses       9740     9731       -9     
+ Partials     1397     1396       -1     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f1c499...a81c31b. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nwnt nwnt force-pushed the add-range-by-value-test branch from c4dc349 to cd623ae Compare February 6, 2026 15:47
@nwnt nwnt force-pushed the add-range-by-value-test branch from cd623ae to febc06c Compare February 6, 2026 16:39
@nwnt nwnt force-pushed the add-range-by-value-test branch from febc06c to 81cc8f7 Compare February 6, 2026 17:14
@k8s-ci-robot k8s-ci-robot added size/L and removed size/M labels Feb 6, 2026
@nwnt nwnt force-pushed the add-range-by-value-test branch from 81cc8f7 to a81c31b Compare February 11, 2026 11:24
@nwnt
Copy link
Member Author

nwnt commented Feb 11, 2026

/retest

@nwnt
Copy link
Member Author

nwnt commented Feb 11, 2026

@serathius ready for your review now. This modifies the test data by shuffling the values, adds new slices for sort by values, and adds new sort by value test cases (plus modifies the existing one that does a sort by value).

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nwnt, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@serathius serathius merged commit a564924 into etcd-io:main Feb 11, 2026
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants