Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github/workflows: remove e2e jobs #18454

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

ivanvc
Copy link
Member

@ivanvc ivanvc commented Aug 16, 2024

These jobs have been long-running on the prow infrastructure, thanks to the work from the pull request kubernetes/test-infra#31257. Since they are required (kubernetes/test-infra#33330), it should be safe to remove the GitHub actions.

Part of kubernetes/test-infra#32754 / kubernetes/k8s.io#6102

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

These jobs have been long-running on the prow infrastructure, thanks to
the work from the pull request kubernetes/test-infra#31257. Since they
are required (kubernetes/test-infra#33330), it should be safe to remove
the GitHub actions.

Signed-off-by: Ivan Valdes <[email protected]>
@k8s-ci-robot k8s-ci-robot added github_actions Pull requests that update GitHub Actions code size/M labels Aug 16, 2024
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 68.81%. Comparing base (39b711f) to head (1842d07).
Report is 7 commits behind head on main.

Current head 1842d07 differs from pull request most recent head fbd4fa4

Please upload reports for the commit fbd4fa4 to get more accurate results.

Files Patch % Lines
server/storage/mvcc/hash.go 33.33% 1 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
Files Coverage Δ
server/storage/mvcc/key_index.go 64.70% <100.00%> (+2.27%) ⬆️
server/storage/mvcc/hash.go 97.10% <33.33%> (-2.90%) ⬇️

... and 20 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #18454      +/-   ##
==========================================
+ Coverage   68.77%   68.81%   +0.04%     
==========================================
  Files         420      420              
  Lines       35490    35490              
==========================================
+ Hits        24407    24423      +16     
+ Misses       9654     9638      -16     
  Partials     1429     1429              

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39b711f...fbd4fa4. Read the comment docs.

@ivanvc
Copy link
Member Author

ivanvc commented Aug 16, 2024

/retest

Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks @ivanvc, the prow e2e presubmits for arm64, 386 and amd64 look to be behaving well.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, ivanvc, jmhbnz, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ahrtr,jmhbnz,serathius]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jmhbnz jmhbnz merged commit f402c2a into etcd-io:main Aug 19, 2024
45 checks passed
@ivanvc ivanvc deleted the delete-e2e-github-actions branch August 19, 2024 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved github_actions Pull requests that update GitHub Actions code size/M
Development

Successfully merging this pull request may close these issues.

6 participants