Present field selection table mass actions in a menu #1513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
travjenkins
reviewed
Mar 17, 2025
src/lang/en-US/Workflows.ts
Outdated
Comment on lines
248
to
251
| 'fieldSelection.massActionMenu.recommended.label': `Default`, | ||
| 'fieldSelection.massActionMenu.recommended.description': `Allow the connector to dynamically select fields`, | ||
| 'fieldSelection.massActionMenu.excludeAll.label': `Exclude All`, | ||
| 'fieldSelection.massActionMenu.excludeAll.description': `Exclude non-essential fields`, |
There was a problem hiding this comment.
I could go either way - but it does seem a bit weird for one option to have All in the label and the other does not. But something like Default All is kinda odd.
travjenkins
reviewed
Mar 17, 2025
| loading={loading} | ||
| projections={projections} | ||
| selectedValue={ | ||
| selectionAlgorithm === 'excludeAll' ? 'exclude' : 'default' |
There was a problem hiding this comment.
Why are we storing the algorithm so we have to use a ternary op?
travjenkins
reviewed
Mar 17, 2025
src/components/editor/Bindings/FieldSelection/FieldActions/MenuOption.tsx
Outdated
Show resolved
Hide resolved
travjenkins
reviewed
Mar 17, 2025
src/components/editor/Bindings/FieldSelection/FieldActions/MenuOption.tsx
Outdated
Show resolved
Hide resolved
travjenkins
reviewed
Mar 17, 2025
src/components/editor/Bindings/FieldSelection/FieldActions/MenuActions.tsx
Show resolved
Hide resolved
…ction-buttons-with-menu
…ction-buttons-with-menu
…ction-buttons-with-menu
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
The issues directly below are completely resolved by this PR:
#1505
Changes
1505
The following features are included in this PR:
Replace the existing button group that surfaces field selection mass actions with a single button which will open a menu of field selection mass actions.
The button label for this CTA should be Mode.
Menu item content will consist of a header identifying a mass action and a (short) description of the action.
A radio button should be used to select a menu item.
The menu will consist of two actions located in the bottom, right corner: Cancel and Apply.
Tests
Manually tested
Approaches to testing are as follows:
Automated tests
N/A
Playwright tests ran locally
Screenshots
Mode CTA disabled | Field selection view loading
Mode CTA enabled | Menu closed
Mode CTA enabled | Menu open