Display provider-specific logo for Azure data-planes #1497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
The issues directly below are completely resolved by this PR:
#1494
Changes
1494
The following features are included in this PR:
Display the data-plane provider-specific logo for Azure data-planes where applicable.
Extend unit test coverage for data-plane utils.
Tests
Manually tested
Approaches to testing are as follows:
Automated tests
Test coverage extended for the following utils:
formatDataPlaneNameparseDataPlaneNamePlaywright tests ran locally
Screenshots
Light Mode
Data-plane selector | Menu options
Data-plane selector | Public, Azure data-plane selected
Data-plane selector | Private, Azure data-plane selected
Dark Mode
Data-plane selector | Menu options
Data-plane selector | Public, Azure data-plane selected
Data-plane selector | Private, Azure data-plane selected