Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data-plane-controller: add azure_application_client_id to table #2017

Merged
merged 1 commit into from
Mar 19, 2025

Conversation

mdibaiee
Copy link
Member

@mdibaiee mdibaiee commented Mar 19, 2025

Description:

  • This is necessary to construct the URL for authorizing the Azure Application access to customer storage in est_dry_dock details and potentially in the future in the UI

Workflow steps:

(How does one use this feature, and how has it changed)

Documentation links affected:

(list any documentation links that you created, or existing ones that you've identified as needing updates, along with a brief description)

Notes for reviewers:

(anything that might help someone review this PR)


This change is Reviewable

@mdibaiee mdibaiee requested a review from jgraettinger March 19, 2025 10:57
Copy link
Member

@jgraettinger jgraettinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mdibaiee mdibaiee merged commit 36472c2 into master Mar 19, 2025
2 of 3 checks passed
@mdibaiee mdibaiee deleted the mahdi/dpc-az-client-id branch March 19, 2025 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants