ops-catalog: update bundled template ... and unrelated agent query perf fix #2012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psFried
changed the title
psFried
force-pushed
the
phil/ops-catalog-bundle
branch
from
85fa513 to
39e1a8c
Compare
I forgot to update the bundled template in the previous PR, which updated the flow.yaml.
The `agent_sql::live_specs::fetch_live_specs` function is executed very frequently in a number of different contexts. We don't always need to resolve the user and/or spec capabilities, but it turns out that fetching them can take quite a while. This updates `fetch_live_specs` to use some boolean parameters to control whether user and spec capabilities are queried. Callsites are all updated so that we can skip fetching them in the common cases where they're not needed. This whole commit is admittedly a bit of a hack. The better solution would be to use a `Snapshot` to determine capabilities in the agent if necessary. But this was pretty easy and simple, and so seems worthile to alleviate some strain on the database.
psFried
force-pushed
the
phil/ops-catalog-bundle
branch
from
39e1a8c to
a764889
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I forgot to update the bundled template in the previous PR, which updated the flow.yaml.
Also includes a quick and dirty improvement to an agent sql query.
This change is