control-plane: bug fixes related to ops catalog changes#2002
Merged
Conversation
These constraints were removed from the original `ops_catalog_status` migration in order to allow legacy agent processes to create new data planes. This just breaks out those constraints to a separate migration.
Fixes a boneheaded mistake in the L1 events derivation, and adds a test verifying the behavior. This had been a last-minute decision to validate the type of `/fields/error`, since the events schema only allows it to be a string. Note that it's not technically _necessary_ for `error` to be constrained to strings, but it seemed like a more prudent starting point, given that events are intended to communicate errors to users.
A previous migration broke the new_free_trial_tenants view. This fixes it, and adds a sql test.
psFried
changed the title
jgraettinger
approved these changes
Mar 17, 2025
supabase/migrations/20250312121737_data-planes-events-column-constraints.sql
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rolls up a few fixes related to the ops catalog changes:
ops_catalog_statusmigration in order to allow legacy agent processes to create new data planes. This just breaks out those constraints to a separate migration./fields/erroris a string on events documents, and it broke the whole thing. This fixes it and adds a test, which really should have been there from the beginning.new_free_trial_tenantsview. The last line of the view definition got missed during the copypasta, which caused us to send out a bunch of free trial emails accidentally. This fixes it and adds a sql test.This change is