Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop MSRV to 1.65 and bump toml, mock_instant #381

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Dirreke
Copy link
Contributor

@Dirreke Dirreke commented Jul 13, 2024

As toml has drop their MSRV to 1.65(toml-rs/toml#730), we could cancel the version limit of toml and drop our MSRV to 1.65 too.

@Dirreke Dirreke requested review from estk and gadunga as code owners July 13, 2024 07:26
@Dirreke Dirreke force-pushed the bump-dependencies branch from 58f7468 to 0254d52 Compare July 13, 2024 07:28
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.76%. Comparing base (8ab1b34) to head (0254d52).
Report is 2 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #381      +/-   ##
==========================================
+ Coverage   63.39%   63.76%   +0.37%     
==========================================
  Files          24       25       +1     
  Lines        1557     1565       +8     
==========================================
+ Hits          987      998      +11     
+ Misses        570      567       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bconn98
Copy link
Collaborator

bconn98 commented Jul 13, 2024

I'm good with dropping the toml limitation. However, is there implicit benefit to dropping the MSRV? On a separate thread a few months back, there had been talk of ~1 year MSRV support.

@Dirreke
Copy link
Contributor Author

Dirreke commented Jul 13, 2024

IMO, the lower MSRV is, the more user can use log4rs. As we dont need the new feature in higher version of MSRV now, I believe dropping MSRV has benefits. I remember our policy is at least 1 year MSRV, so it's ok to downgrade MSRV.

However, if you don't want to downgrade it, I'm also good about that and I can edit this PR. Thanks!

@bconn98
Copy link
Collaborator

bconn98 commented Jul 17, 2024

Good enough for me. The only "reason" I had to bump was once_cell is getting merged into std. But it's not new / needed functionality so not a priority.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants