Track monetized and non-monetized time properly

[sharon-wang]

Fixes: #79

Previously, we assumed that as soon as we see a payment pointer on a website (at an origin), that the origin is always considered to be monetized. So, once we decided that an origin is monetized, any time spent on the site was considered monetized time spent on the site. However, this is a flawed assumption, since sites such as YouTube may only contain payment pointers (meta tags) on specific videos and not others. So, some of the time spent on the site is monetized and some is non-monetized. This PR updates how we track time by checking for a payment pointer as we track time, to store
time spent properly.

We no longer store detailed data for every single origin -- only monetized origins are stored. Additionally, counting monetized
visits and associated functions have been removed as they were not being used or were redundant. The isCurrentlyMonetized field has been removed from AkitaOriginData as it was a major part of the problematic monetized time tracking. The text in the top site detail has been updated to point out that the time is monetized time, just to be clear.

[sharon-wang]

I've tested this with the Coil extension installed and I'm seeing the correct outcome.

Test steps

1. Ensure Coil is installed and user is logged in
2. Install Akita from scratch (no existing data)
3. Go to a web monetized YouTube vid such as https://www.youtube.com/watch?v=sApKXmwhg4g&ab_channel=Simmer.io
4. Watch the video for X minutes
5. Open Akita
6. Hover on top site circle for YouTube, see that X minutes of monetized time on the site is indicated
7. Go to the YouTube homepage (not a monetized page) and stay there for Y minutes
8. Open Akita
9. Hover on top site circle for YouTube, see that X minutes of monetized time on the site is still indicated, since the Y minutes on the homepage do not count as monetized time

[sharon-wang]

Also a note that you may need to install Akita from scratch again, since the data storage has changed. You might see weird behaviour in the UI otherwise.

[vezwork]

Going to test locally now. I have one question:

Currently you are counting any time on a page containing a monetization tag as monetized. I'm wondering what your thoughts are on instead not counting time as monetized until after the cachedPaymentPointer is validated? Then the monetized time would match more closely with the amount of time you see the monetized Akita extension icon, and invalid payment pointers would not count for monetized time.

[sharon-wang]

Currently you are counting any time on a page containing a monetization tag as monetized. I'm wondering what your thoughts are on instead not counting time as monetized until after the cachedPaymentPointer is validated? Then the monetized time would match more closely with the amount of time you see the monetized Akita extension icon, and invalid payment pointers would not count for monetized time.

The cachedPaymentPointer would have already been validated 1 second prior (previous setInterval iteration). We could move setting previousStoreTime = currentTime; to after the paymentPointerOnPage is validated and cachedPaymentPointer is set to paymentPointerOnPage?

[vezwork]

The cachedPaymentPointer would have already been validated 1 second prior (previous setInterval iteration).

There is no garantee that the cachedPaymentPointer has been validated. For example: if isPaymentPointerValid was called to check if the cachedPaymentPointer was valid, but it came back as invalid, cachedPaymentPointer would still be non-null, or it's quite possible and even most likely that validation will take more than 1 second and cachedPaymentPointer would also be non-null in that case.

We could move setting previousStoreTime = currentTime; to after the paymentPointerOnPage is validated and cachedPaymentPointer is set to paymentPointerOnPage?

I think something along these lines could work but my suggestion would be just to change line 145 to

const isMonetizedTime = cachedPaymentPointer !== null && await isPaymentPointerRecentlyValidated(cachedPaymentPointer);

This should work, noting that time before the payment pointer is validated is not counted as monetized time even after the payment pointer is validated. I think this is reasonable since it is necessary to validate a payment pointer before monetization starts.

[vezwork]

Found a bug in my testing:

Github is showing up as a top monetized site although it shouldn't be. Strangely, the UI even says that github has no monetized time.
This is only happening after I visit another site which is actually monetized.

[sharon-wang]

The new changes to storeDataIntoAkitaFormat/storeDataIntoAkitaFormatNonMonetized fixes the issue in #98 (comment)

[vezwork]

Nice changes, I would say they improve the code quality and are clear. Just one issue about repeated validations otherwise this looks great.

[vezwork]

Just did some more testing and everything is working great :)

[vezwork]

Thanks for the changes, looks great! Please squash and merge.