Destroy Attributes'
s handle before its parent_link
#662
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As pointed out by @jkotan in a comment to the related PR #660, the same issue as described in #659 also appears for
Attribute
s:If an
Attribute
instance is kept around after the last reference to a file was dropped in client code, the order ofAttribute
's members causes it to first try to close the underlying file before closing its own handle. If the file was opened with close degreeSemi
or the MPI-IO file driver was used, closing the file while theAttribute
is still open is prohibited.This PR, therefore, applies the same fix to
Attribute
as was applied toNode
in #660; that is, it reorders the member ofAttribute
to ensure that the handle is destroyed first, before attempting to close the file through destroying the link.