Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 657: make ebool test file names different #658

Merged
merged 1 commit into from
Nov 20, 2024
Merged

Issue 657: make ebool test file names different #658

merged 1 commit into from
Nov 20, 2024

Conversation

jkotan
Copy link
Collaborator

@jkotan jkotan commented Nov 19, 2024

It resolves #657 by making ebool test file names different

ggoneiESS
ggoneiESS approved these changes Nov 19, 2024
View reviewed changes
Copy link
Member

@ggoneiESS ggoneiESS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix looks fine but with Catch2 you should be able to put the scenario in a function and then we don't have to duplicate everything twice with only two variables being different, which might be worth doing? Happy to approve either way.

@jkotan
Copy link
Collaborator Author

jkotan commented Nov 20, 2024

Hello @ggoneiESS, thank you for your review. If you would like to optimize the test I'm happy to accect your PR.

@jkotan jkotan merged commit 517a81e into master Nov 20, 2024
60 checks passed
@jkotan jkotan deleted the issue_657 branch November 20, 2024 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggoneiESS ggoneiESS ggoneiESS approved these changes

@yuelongyu yuelongyu Awaiting requested review from yuelongyu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nexus tests sporadically fail when executed in parallel
2 participants
@jkotan @ggoneiESS