Skip to content

Commit

Permalink
Removed contrib/string.hpp from dataset.cpp
Browse files Browse the repository at this point in the history
Update #548
  • Loading branch information
eugenwintersberger committed Aug 8, 2022
1 parent 0c049cd commit 1bb573c
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 14 deletions.
11 changes: 0 additions & 11 deletions src/h5cpp/node/dataset.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@
#include <h5cpp/node/functions.hpp>
#include <h5cpp/filter/external_filter.hpp>
#include <h5cpp/error/error.hpp>
#include <h5cpp/contrib/stl/string.hpp>
#include <h5cpp/core/utilities.hpp>

namespace hdf5 {
Expand Down Expand Up @@ -208,16 +207,6 @@ unsigned long long Dataset::chunk_storage_size(

#endif

void Dataset::write(const char *data,const property::DatasetTransferList &dtpl)
{
write(std::string(data),dtpl);
}

void Dataset::write(const char *data,const property::DatasetTransferList &dtpl) const
{
write(std::string(data),dtpl);
}

filter::ExternalFilters Dataset::filters() const
{
filter::ExternalFilters efilters = filter::ExternalFilters();
Expand Down
15 changes: 12 additions & 3 deletions src/h5cpp/node/dataset.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -312,16 +312,25 @@ class DLL_EXPORT Dataset : public Node
//!
//! \brief write entire dataset
//!
//! Write the entire dataset from an instance of const char *
//! Write the entire dataset from an instance of const char *.
//! Since we consider char* data as strings we have to implement these
//! two methods as templates in order to give the user the choice to
//! decide which traits he wants to use in order to write the strings.
//!
//! \throws std::runtime_error in caes of a failure
//! \param data pointer to the source instance of const char *
//! \param dtpl reference to a dataset transfer property list
//!
void write(const char *data,const property::DatasetTransferList &dtpl =
property::DatasetTransferList::get());
property::DatasetTransferList::get())
{
write(std::string(data),dtpl);
}
void write(const char *data,const property::DatasetTransferList &dtpl =
property::DatasetTransferList::get()) const;
property::DatasetTransferList::get()) const
{
write(std::string(data),dtpl);
}

//!
//! \brief write dataset chunk
Expand Down

0 comments on commit 1bb573c

Please sign in to comment.