WIP change lb density to delta_density in the generated kernels#4775
Open
itischler wants to merge 1 commit intoespressomd:pythonfrom
Open
WIP change lb density to delta_density in the generated kernels#4775itischler wants to merge 1 commit intoespressomd:pythonfrom
itischler wants to merge 1 commit intoespressomd:pythonfrom
Conversation
|
Your pull request does not meet our code formatting rules. Specifically, I suggest you make the following changes: diff --git a/maintainer/walberla_kernels/generate_lb_kernels.py b/maintainer/walberla_kernels/generate_lb_kernels.py
index 000cd7be9..af49cded5 100644
--- a/maintainer/walberla_kernels/generate_lb_kernels.py
+++ b/maintainer/walberla_kernels/generate_lb_kernels.py
@@ -52,7 +52,7 @@ else:
target = ps.Target.CPU
# Make sure we have the correct versions of the required dependencies
-#for module, requirement in [(ps, "==1.2"), (lbmpy, "==1.2")]:
+# for module, requirement in [(ps, "==1.2"), (lbmpy, "==1.2")]:
# assert pkg_resources.packaging.specifiers.SpecifierSet(requirement).contains(module.__version__), \
# f"{module.__name__} version {module.__version__} doesn't match requirement {requirement}"
diff --git a/src/walberla_bridge/tests/kernels_unit_tests.cpp b/src/walberla_bridge/tests/kernels_unit_tests.cpp
index c9143da79..f0289b37b 100644
--- a/src/walberla_bridge/tests/kernels_unit_tests.cpp
+++ b/src/walberla_bridge/tests/kernels_unit_tests.cpp
@@ -172,7 +172,8 @@ BOOST_AUTO_TEST_CASE(macroscopic_accessor_equilibrium_distribution) {
}
}
{
- auto const ref_d = delta_rho_d * 1. / 36. + rho_d * (5. / 12. * x * x + 2. / 12. * x);
+ auto const ref_d =
+ delta_rho_d * 1. / 36. + rho_d * (5. / 12. * x * x + 2. / 12. * x);
auto const ref_f = static_cast<float>(ref_d);
for (auto const direction : {Direction::NE, Direction::TN, Direction::TE}) {
auto const pop_f = EquilibriumDistribution::get(direction, u_f, rho_f);
@@ -182,7 +183,8 @@ BOOST_AUTO_TEST_CASE(macroscopic_accessor_equilibrium_distribution) {
}
}
{
- auto const ref_d = delta_rho_d * 1. / 36. + rho_d * (5. / 12. * x * x - 2. / 12. * x);
+ auto const ref_d =
+ delta_rho_d * 1. / 36. + rho_d * (5. / 12. * x * x - 2. / 12. * x);
auto const ref_f = static_cast<float>(ref_d);
for (auto const direction : {Direction::SW, Direction::BS, Direction::BW}) {
auto const pop_f = EquilibriumDistribution::get(direction, u_f, rho_f);To apply these changes, please do one of the following:
You can run Please note that there are often multiple ways to correctly format code. As I am just a robot, I sometimes fail to identify the most aesthetically pleasing way. So please look over my suggested changes and adapt them where the style does not make sense. |
|
Your pull request does not meet our code style rules. Pylint summary: You can generate these warnings with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes: