-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[VSC-1472/1207] add new idf size format support #1330
Conversation
Download the artifacts for this pull request: |
The issue seems to be associated to the selected target. For ESP32 > Wrover Kit I see the table being rendered incorrectly on windows, but complete on WSL, while when selecting ESP32C6 I see the error popup without any size table. |
Fixed the issues of files not being added into their respective archive on Windows.
PTAL again @Fabricio-ESP @radurentea |
Data is rendering as expected now. Th eone item that can be treated in other PR, related to customer experience improvement. The size chart and table are not updated if the user re-runs the command before closing the previous results. Either we close it and open a new window with the resilts, or update the results in place. It is not clear to the user that the results presented are outdated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Support new esp-idf-size JSON format which provide more map file information in
ESP-IDF: Size analysis of the binaries
command UI.This feature is supported for ESP-IDF v5.3 and higher, when older versions are used the extension will use previous IDF Size UI
Type of change
Steps to test this pull request
Provide a list of steps to test changes in this PR and required output
ESP-IDF: Size analysis of the binaries
command with ESP-IDF v5.3.0 or higherExpected behaviour:
Result similar to https://docs.espressif.com/projects/esp-idf/en/latest/esp32/api-guides/tools/idf-size.html?highlight=size
Expected output:
https://docs.espressif.com/projects/esp-idf/en/latest/esp32/api-guides/tools/idf-size.html?highlight=size
How has this been tested?
Manual testing of extension command using both v5.4.0 and v.5.2.2
Test Configuration:
Checklist