Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix pr comment rm build flash telemetry #1328

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

brianignacio5
Copy link
Collaborator

Description

Fix PR comment to update vsix.

Remove build and flash not known errors from telemetry. These are user issues not handle by extension.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Steps to test this pull request

Not sure how to test the PR comment before release. Run workflow for the branch I guess.

Telemetry is not possible to test output.

Test Configuration:

  • ESP-IDF Version: All
  • OS (Windows,Linux and macOS): All

Checklist

  • PR Self Reviewed
  • Applied Code formatting
  • Added Documentation
  • Added Unit Test
  • Verified on all platforms - Windows,Linux and macOS

Copy link
Collaborator

@radurentea radurentea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brianignacio5 brianignacio5 merged commit f5ecca2 into master Oct 23, 2024
6 checks passed
@brianignacio5 brianignacio5 deleted the bugfix/fix-pr-comment-workflow branch October 23, 2024 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants