Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable/Disable status bar icons in Commands Tree view #1314

Merged
merged 5 commits into from
Sep 27, 2024

Conversation

brianignacio5
Copy link
Collaborator

@brianignacio5 brianignacio5 commented Sep 18, 2024

Description

Add Checkbox in Espressif tab Commands to be enable/disable in status bar.

Screenshot 2024-09-26 at 16 15 35

Fixes #1307

Type of change

  • New feature (non-breaking change which adds functionality)

Steps to test this pull request

Provide a list of steps to test changes in this PR and required output

  1. Click on "Espressif" icon tab. You can see a list of commands with checkbox. If you click the checkbox to disable it, the icon in the status bar will disappear. The same for the opposite.
  • Expected behaviour:
    Icons appear and disappear from status bar based on user selection.

  • Expected output:

How has this been tested?

Manual testing

Checklist

  • PR Self Reviewed
  • Applied Code formatting
  • Added Documentation
  • Added Unit Test
  • Verified on all platforms - Windows,Linux and macOS

@brianignacio5 brianignacio5 self-assigned this Sep 18, 2024
Copy link

github-actions bot commented Sep 18, 2024

Download the artifacts for this pull request:

@brianignacio5 brianignacio5 force-pushed the feature/manage-status-bar-commands branch from 58bc11c to 86e49e4 Compare September 18, 2024 10:30
@brianignacio5 brianignacio5 mentioned this pull request Sep 19, 2024
5 tasks
@brianignacio5 brianignacio5 added this to the 1.9.0 milestone Sep 19, 2024
@brianignacio5 brianignacio5 force-pushed the feature/manage-status-bar-commands branch from b6109c4 to 9cf35d3 Compare September 23, 2024 09:26
@Fabricio-ESP
Copy link
Collaborator

Fabricio-ESP commented Sep 25, 2024

Confirmed the feature is working as expected on Windows and Linux machines.
Recommendation is to sort the command list among the commands that allow being pinned to the toolbar and the commands that cannot be added. So it gets visually better to see the command icons and the checkbox.
Alternatively align the command icons, and leave an empty space instead of a checkbox for commands that does not support it.

This can be considered an improvement rather than a fix.
image

Copy link
Collaborator

@Fabricio-ESP Fabricio-ESP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider the improvement mentioned on the comment.

@brianignacio5 brianignacio5 force-pushed the feature/manage-status-bar-commands branch from 495520e to 8a00205 Compare September 26, 2024 07:24
@Fabricio-ESP
Copy link
Collaborator

Looks fantastic! Thanks.

@brianignacio5 brianignacio5 merged commit 5e72a83 into master Sep 27, 2024
6 checks passed
@brianignacio5 brianignacio5 deleted the feature/manage-status-bar-commands branch September 27, 2024 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants