-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix display of monitor the device when flash fails #1286
Conversation
Download the artifacts for this pull request: |
Hi @brianignacio5, PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
HI @AndriiFilippov, PTAL |
@radurentea hi ! Tested under: LGTM 👍 Only question related to output: Nothing critical but should we somehow separate this messages from each other with space ? or simply clean console |
Hi @AndriiFilippov, Regarding the messages that don't clean themselves, I think it's ok the way it is. The user can use the clear console feature if they want it. We could add a feature to add timestamps for the ESP-IDF output channel in the future and disable it by default and offer users the possibility of enabling it by using an idf paramater. |
Description
You can monitor with ESP-IDF: Monitor your device command
to:You can monitor your device with ESP-IDF: Monitor command
JIRA: https://jira.espressif.com:8443/browse/VSC-1431
Type of change
Steps to test this pull request
Preparation:
Ensure you have the latest version of the VS Code Extension source code:
Set up a test ESP project that can be flashed.
Test Scenarios:
A. Normal Behavior (Baseline):
B. Simulated Flash Failure:
src\flash\uartFlash.ts
in the VS Code Extension source code.try{
insideasync function flashCommand
:Like this:
How has this been tested?
As described above
Test Configuration:
Checklist