-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed Spelling Mistake (ESPTOOL-850) #974
Conversation
👋 Hello GreenDiscord, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. Click to see more instructions ...
Review and merge process you can expect ...
|
Hello @GreenDiscord, We'll merge it soon, I just need you to change the commit message (please see the previous message from our bot). I suggest something like Thank you! |
@radimkarnis there ya go :D |
Thanks! All looks good now. I will put this through our internal queue and merge it. |
Hey @GreenDiscord, Turns out your commit is not on top of the current master branch. Could you please rebase? I could do that for you, but then you would lose the github credit for the contribution (since I would alter your commit). Also, my suggestion of the |
This change fixes the following bug(s):
I have tested this change with the following hardware & software combinations:
NO TESTINGI have run the esptool.py automated integration tests with this change and the above hardware:
NO TESTING