Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow the espefuse.py to work when coding scheme == 3 (ESPTOOL-803) #950

Closed
wants to merge 1 commit into from

Conversation

klondi
Copy link
Contributor

@klondi klondi commented Jan 28, 2024

When the coding scheme efuse has the value 3, the efuse fields should still be considered to be 256 bits long. Unfortunately, the tool fails miserably with error "A fatal error occurred: Coding scheme (3) not supported"

This patch addresses that by handling the case when coding scheme is 0 in the same way as if coding scheme was 1.

This change fixes the following bug(s):

I have tested this change with the following hardware & software combinations:

ESP32 with coding scheme == 3

I have run the esptool.py automated integration tests with this change and the above hardware:

NO TESTING

Signed-off-by: Francisco Blas (klondike) Izquierdo Riera <[email protected]>
Copy link

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello klondi, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests via this public GitHub repository.

This GitHub project is public mirror of our internal git repository

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved, we synchronize it into our internal git repository.
4. In the internal git repository we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
5. If the change is approved and passes the tests it is merged into the default branch.
5. On next sync from the internal git repository merged change will appear in this public GitHub repository.

Generated by 🚫 dangerJS against 411ae58

@github-actions github-actions bot changed the title fix: Allow the espefuse.py to work when coding scheme == 3 fix: Allow the espefuse.py to work when coding scheme == 3 (ESPTOOL-803) Jan 28, 2024
@KonstantinKondrashov
Copy link
Collaborator

Hi @klondi!
Thanks for your contribution. Yes, I confirm that for the coding scheme = 3 there is no support for now. I will check other places where it can affect, it can be easily added. It relates to the ESP32 chip only.

@KonstantinKondrashov
Copy link
Collaborator

KonstantinKondrashov commented Jan 30, 2024

I will make support for coding scheme == 3 for espefuse.py but I want to mention that IDF does not support this mode.
If you got the original chip with the coding scheme == 0b01 ("3/4") and then burned another bit to get the "None" coding scheme (val==0b11) then if there were data written in BLOCK1-3 you will see that data in these BLCOKs are mixed with the coding data. It is not recommended way. Why did not do that?

esptool.py recognizes this state as - Coding Scheme Invalid.

This support will allow you to burn data with espefuse.py. However, using this chip with IDF can be limited.
Thanks.
image

@radimkarnis
Copy link
Collaborator

@klondi thank you for the contribution!

peterdragun pushed a commit to peterdragun/esptool that referenced this pull request Jul 16, 2024
Signed-off-by: Francisco Blas (klondike) Izquierdo Riera <[email protected]>

Closes espressif#950
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants