Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(macos-amd64): Add Intel-based macOS as target (ESPTOOL-957) #1031

Closed
wants to merge 1 commit into from

Conversation

lucasssvaz
Copy link
Contributor

@lucasssvaz lucasssvaz commented Oct 30, 2024

Arduino and many other applications still require x86_64 binaries for MacOS. We will need these binaries for releasing important updates like ESP32-P4 support in Arduino.

This PR adds the macos-amd64 target for the esptool, making it available to Intel-based CPUs on MacOS.

Ideally the current macos target should be renamed to macos-arm64 for consistency but it will be a breaking change, so it can be postponed until a new major release.

This change fixes the following bug(s):

No recent available esptool for MacOS Intel CPUs.

I have run the esptool.py automated integration tests with this change and the above hardware:

Tested in fork with CI.

Copy link

github-actions bot commented Oct 30, 2024

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello lucasssvaz, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests via this public GitHub repository.

This GitHub project is public mirror of our internal git repository

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved, we synchronize it into our internal git repository.
4. In the internal git repository we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
5. If the change is approved and passes the tests it is merged into the default branch.
5. On next sync from the internal git repository merged change will appear in this public GitHub repository.

Generated by 🚫 dangerJS against 81092e7

@github-actions github-actions bot changed the title feat(macos-amd64): Add Intel-based macOS as target feat(macos-amd64): Add Intel-based macOS as target (ESPTOOL-957) Oct 30, 2024
@lucasssvaz lucasssvaz closed this Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant