feat(macos-amd64): Add Intel-based macOS as target (ESPTOOL-957) #1031
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Arduino and many other applications still require
x86_64
binaries for MacOS. We will need these binaries for releasing important updates like ESP32-P4 support in Arduino.This PR adds the
macos-amd64
target for the esptool, making it available to Intel-based CPUs on MacOS.Ideally the current
macos
target should be renamed tomacos-arm64
for consistency but it will be a breaking change, so it can be postponed until a new major release.This change fixes the following bug(s):
No recent available esptool for MacOS Intel CPUs.
I have run the esptool.py automated integration tests with this change and the above hardware:
Tested in fork with CI.