-
Notifications
You must be signed in to change notification settings - Fork 7.7k
feat(matter): removing wifi requirement for H2 and C5 #11581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release/v3.3.x
Are you sure you want to change the base?
Conversation
👋 Hello SuGlider, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project. Click to see more instructions ...
Review and merge process you can expect ...
|
Memory usage test (comparing PR against master branch)The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.
Click to expand the detailed deltas report [usage change in BYTES]
|
Co-authored-by: Copilot <[email protected]>
...ries/Matter/examples/MatterLambdaSingleCallbackManyEPs/MatterLambdaSingleCallbackManyEPs.ino
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes WiFi provisioning support from CI and examples (shifting to Thread/BLE provisioning), updates the CI configs for all Matter examples to drop the WiFi requirement, and adds new API keywords and a fresh “LambdaSingleCallbackManyEPs” example.
- Deleted the WiFiProvWithinMatter example (its
.ino
andci.json
) since BLE is now used for provisioning. - Stripped
"CONFIG_SOC_WIFI_SUPPORTED=y"
from the CI JSON of existing examples to test Thread-only builds. - Updated
keywords.txt
with new Matter API identifiers and introduced a new “LambdaSingleCallbackManyEPs” example with CI and source.
Reviewed Changes
Copilot reviewed 24 out of 24 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
libraries/Matter/keywords.txt | Added new Matter API keywords (EndPointIdentifyCB , attrOperation_t , and new methods) |
libraries/Matter/examples/WiFiProvWithinMatter/ci.json | Removed WiFi provisioning CI config |
libraries/Matter/examples/WiFiProvWithinMatter/WiFiProvWithinMatter.ino | Removed WiFi provisioning example code |
libraries/Matter/examples/MatterThermostat/ci.json (and similar multiple example folders) | Dropped CONFIG_SOC_WIFI_SUPPORTED=y in example CI requirements |
libraries/Matter/examples/MatterLambdaSingleCallbackManyEPs/ci.json | Added CI config for new lambda‐based multi‐endpoint example |
libraries/Matter/examples/MatterLambdaSingleCallbackManyEPs/MatterLambdaSingleCallbackManyEPs.ino | Added new “LambdaSingleCallbackManyEPs” example implementation |
Description of Change
Arduino Matter 3.3.x Library runs over WiFi or Thread depending on the target SoC.
CI JSON shall be adjusted to test Thread Matter by removing the WiFi requirement.
Removes WiFi Provisioning examples given that it doesn't make any sense because Matter uses BLE for network provisioning.
Updates Library Key Words.
Tests scenarios
CI Only
Related links
None