Skip to content

feat(matter): removing wifi requirement for H2 and C5 #11581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 29 commits into
base: release/v3.3.x
Choose a base branch
from

Conversation

SuGlider
Copy link
Collaborator

@SuGlider SuGlider commented Jul 10, 2025

Description of Change

Arduino Matter 3.3.x Library runs over WiFi or Thread depending on the target SoC.
CI JSON shall be adjusted to test Thread Matter by removing the WiFi requirement.

Removes WiFi Provisioning examples given that it doesn't make any sense because Matter uses BLE for network provisioning.
Updates Library Key Words.

Tests scenarios

CI Only

Related links

None

@SuGlider SuGlider self-assigned this Jul 10, 2025
@SuGlider SuGlider requested a review from lucasssvaz as a code owner July 10, 2025 14:21
Copy link
Contributor

github-actions bot commented Jul 10, 2025

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message "Update ci.json":
    • summary looks empty
    • type/action looks empty
  • the commit message "feta(matter): update keywords.txt":
    • type/action should be one of [change, ci, docs, feat, fix, refactor, remove, revert, test]
  • the commit message "matter(feat): add network connection waiting time":
    • type/action should be one of [change, ci, docs, feat, fix, refactor, remove, revert, test]

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 10 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

👋 Hello SuGlider, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 077110a

@SuGlider SuGlider added the Area: Matter Issues and Feature Request about Matter Protocol label Jul 10, 2025
@SuGlider SuGlider added this to the 3.3.0 milestone Jul 10, 2025
@SuGlider SuGlider moved this from Todo to In Progress in Arduino ESP32 Core Project Roadmap Jul 10, 2025
@SuGlider SuGlider marked this pull request as draft July 10, 2025 14:37
@SuGlider SuGlider requested a review from Copilot July 10, 2025 19:12
Copilot

This comment was marked as outdated.

Copy link
Contributor

Memory usage test (comparing PR against master branch)

The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.

MemoryFLASH [bytes]FLASH [%]RAM [bytes]RAM [%]
TargetDECINCDECINCDECINCDECINC
ESP32C5000.000.00000.000.00
ESP32S3000.000.00000.000.00
ESP32S2000.000.00000.000.00
ESP32C3000.000.00000.000.00
ESP32C6000.000.00000.000.00
ESP32H2000.000.00000.000.00
ESP32000.000.00000.000.00
Click to expand the detailed deltas report [usage change in BYTES]
TargetESP32C5ESP32S3ESP32S2ESP32C3ESP32C6ESP32H2ESP32
ExampleFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAM
libraries/Matter/examples/MatterColorLight--------------
libraries/Matter/examples/MatterCommissionTest--------------
libraries/Matter/examples/MatterComposedLights--------------
libraries/Matter/examples/MatterContactSensor--------------
libraries/Matter/examples/MatterDimmableLight--------------
libraries/Matter/examples/MatterEnhancedColorLight--------------
libraries/Matter/examples/MatterEvents--------------
libraries/Matter/examples/MatterFan--------------
libraries/Matter/examples/MatterHumiditySensor--------------
libraries/Matter/examples/MatterLambdaSingleCallbackManyEPs--------------
libraries/Matter/examples/MatterMinimum--------------
libraries/Matter/examples/MatterOccupancySensor--------------
libraries/Matter/examples/MatterOnIdentify--------------
libraries/Matter/examples/MatterOnOffLight--------------
libraries/Matter/examples/MatterOnOffPlugin--------------
libraries/Matter/examples/MatterPressureSensor--------------
libraries/Matter/examples/MatterSmartButon--------------
libraries/Matter/examples/MatterTemperatureLight--------------
libraries/Matter/examples/MatterTemperatureSensor--------------
libraries/Matter/examples/MatterThermostat--------------

@SuGlider SuGlider requested a review from Copilot July 10, 2025 21:55
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes WiFi provisioning support from CI and examples (shifting to Thread/BLE provisioning), updates the CI configs for all Matter examples to drop the WiFi requirement, and adds new API keywords and a fresh “LambdaSingleCallbackManyEPs” example.

  • Deleted the WiFiProvWithinMatter example (its .ino and ci.json) since BLE is now used for provisioning.
  • Stripped "CONFIG_SOC_WIFI_SUPPORTED=y" from the CI JSON of existing examples to test Thread-only builds.
  • Updated keywords.txt with new Matter API identifiers and introduced a new “LambdaSingleCallbackManyEPs” example with CI and source.

Reviewed Changes

Copilot reviewed 24 out of 24 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
libraries/Matter/keywords.txt Added new Matter API keywords (EndPointIdentifyCB, attrOperation_t, and new methods)
libraries/Matter/examples/WiFiProvWithinMatter/ci.json Removed WiFi provisioning CI config
libraries/Matter/examples/WiFiProvWithinMatter/WiFiProvWithinMatter.ino Removed WiFi provisioning example code
libraries/Matter/examples/MatterThermostat/ci.json (and similar multiple example folders) Dropped CONFIG_SOC_WIFI_SUPPORTED=y in example CI requirements
libraries/Matter/examples/MatterLambdaSingleCallbackManyEPs/ci.json Added CI config for new lambda‐based multi‐endpoint example
libraries/Matter/examples/MatterLambdaSingleCallbackManyEPs/MatterLambdaSingleCallbackManyEPs.ino Added new “LambdaSingleCallbackManyEPs” example implementation
Comments suppressed due to low confidence (1)

@SuGlider SuGlider marked this pull request as ready for review July 11, 2025 03:15
@SuGlider SuGlider moved this from In Progress to In Review in Arduino ESP32 Core Project Roadmap Jul 11, 2025
@SuGlider SuGlider added the Status: Review needed Issue or PR is awaiting review label Jul 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Matter Issues and Feature Request about Matter Protocol Status: Review needed Issue or PR is awaiting review
Projects
Status: In Review
Development

Successfully merging this pull request may close these issues.

1 participant