Skip to content

feat(matter): new matter example #11561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jul 11, 2025
Merged

feat(matter): new matter example #11561

merged 11 commits into from
Jul 11, 2025

Conversation

SuGlider
Copy link
Collaborator

@SuGlider SuGlider commented Jul 7, 2025

Description of Change

This PR creates a new Matter example that demonstrates how to create a multi-endpoint node using a single event callback.

Tests scenarios

Testing the example with ESP32, S3, C3, C6.

Related links

#11535

@SuGlider SuGlider added this to the 3.3.0 milestone Jul 7, 2025
@SuGlider SuGlider self-assigned this Jul 7, 2025
@SuGlider SuGlider added the Area: Matter Issues and Feature Request about Matter Protocol label Jul 7, 2025
@SuGlider SuGlider moved this from Todo to In Progress in Arduino ESP32 Core Project Roadmap Jul 7, 2025
@SuGlider SuGlider marked this pull request as draft July 7, 2025 14:13
Copy link
Contributor

github-actions bot commented Jul 7, 2025

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello SuGlider, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against db60c57

Copy link
Contributor

github-actions bot commented Jul 7, 2025

Memory usage test (comparing PR against master branch)

The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.

MemoryFLASH [bytes]FLASH [%]RAM [bytes]RAM [%]
TargetDECINCDECINCDECINCDECINC
ESP32S3000.000.00000.000.00
ESP32S2000.000.00000.000.00
ESP32C3000.000.00000.000.00
ESP32C6000.000.00000.000.00
ESP32000.000.00000.000.00
Click to expand the detailed deltas report [usage change in BYTES]
TargetESP32S3ESP32S2ESP32C3ESP32C6ESP32
ExampleFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAM
libraries/Matter/examples/MatterLambdaSingleCallbackManyEPs----------

@SuGlider SuGlider modified the milestones: 3.3.0, 3.2.1 Jul 10, 2025
@SuGlider SuGlider requested a review from Copilot July 10, 2025 19:12
Copilot

This comment was marked as outdated.

SuGlider and others added 2 commits July 10, 2025 18:56
@SuGlider SuGlider requested a review from Copilot July 10, 2025 21:57
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a new Matter example demonstrating how to create a multi-endpoint node with a single event callback.

  • Added new Matter keywords for endpoint identification and attribute operations.
  • Provided CI configuration for the new example.
  • Introduced an example sketch showcasing multi-endpoint on/off light control via a shared lambda callback.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
libraries/Matter/keywords.txt Added keywords for endpoint identification and attribute operations.
libraries/Matter/examples/MatterLambdaSingleCallbackManyEPs/ci.json Defined CI settings for the new example.
libraries/Matter/examples/MatterLambdaSingleCallbackManyEPs/*.ino New example sketch illustrating multi-endpoint callback usage.
Comments suppressed due to low confidence (1)

libraries/Matter/keywords.txt:119

  • [nitpick] The keyword 'endpointIdentifyCB' has inconsistent casing compared to 'EndPointIdentifyCB'; consider aligning the casing to match existing conventions.
endpointIdentifyCB	KEYWORD2

@SuGlider SuGlider moved this from In Progress to In Review in Arduino ESP32 Core Project Roadmap Jul 11, 2025
@SuGlider SuGlider added the Status: Review needed Issue or PR is awaiting review label Jul 11, 2025
@SuGlider SuGlider marked this pull request as ready for review July 11, 2025 02:33
@SuGlider SuGlider requested a review from lucasssvaz as a code owner July 11, 2025 02:33
@P-R-O-C-H-Y P-R-O-C-H-Y added Status: Pending Merge Pull Request is ready to be merged and removed Status: Review needed Issue or PR is awaiting review labels Jul 11, 2025
@SuGlider SuGlider merged commit 4ee17de into master Jul 11, 2025
21 of 22 checks passed
@SuGlider SuGlider deleted the matter_lambda_example branch July 11, 2025 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Matter Issues and Feature Request about Matter Protocol Status: Pending Merge Pull Request is ready to be merged
Projects
Development

Successfully merging this pull request may close these issues.

4 participants