-
Notifications
You must be signed in to change notification settings - Fork 7.6k
feat(codeowners): Initial CODEOWNERS setup #11397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
👋 Hello lucasssvaz, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project. Click to see more instructions ...
Review and merge process you can expect ...
|
@me-no-dev @SuGlider @P-R-O-C-H-Y @pedrominatel PTAL and see if you would like to change/add/remove something. @rftafas @igrr @Parsaabasi Would you like to be code owners of any specific files ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @lucasssvaz, I agree.
# Note that order matters. The last matching pattern will be used. | ||
|
||
# The default owners are the active developers of the ESP32 Arduino Core. | ||
# Refrain from using @espressif/arduino-esp32 to avoid spamming non-developers with review requests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's also possible to create a group or modify the list of people in arduino-esp32 group if it doesn't serve its purpose
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could create something like "espressif/arduino-devs" with only the main developers. Does it need to be created by one of the organization admins or can we do it ourselves ?
Edit: Created @espressif/arduino-devs. Pending parent team approval to give it write permissions to this repository.
* @lucasssvaz @me-no-dev @P-R-O-C-H-Y @SuGlider | ||
|
||
# CI | ||
/.github/ @lucasssvaz @me-no-dev @P-R-O-C-H-Y |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and optionally espressif/ci here, just in case some workflow has to be updated due to a security issue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We change our CI files quite frequently. Wouldn't this spam the CI team with review notifications? I have never used CODEOWNERS
before so I don't know. The idea is to enable the branch protection rule to require codeowners review and AFAIK this automatically requests the review of all owners.
Some libs are missing from the list. Is that intentional? |
I just added the libs that I knew who the owner is. If there is anything missing just say so and I will add. By default anything that doesn't have a explicit ownership will be owned by @espressif/arduino-devs. This is supposed to be just an initial setup. For example, I will add the BLE ownership when I add the NimBLE support. |
Added suggestions. Just missing the parent team approval now. ![]() @igrr Could you please take a look ? |
2193ac0
to
98ef1ef
Compare
This pull request introduces a new
CODEOWNERS
file to the repository, specifying ownership rules for different parts of the ESP32 Arduino Core project. The file ensures that review requests are directed to the appropriate developers based on the file or directory being modified.Other libraries and files can be added with time. This is only the initial setup.