Remove the dependency on libudev and its corresponding feature
#742
+11
−56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessebraham
force-pushed
the
fixes/libudev
branch
from
6a970e1 to
fbcd8fc
Compare
Not a clean solution, but since this requires large testing in different OSs, what if we merge it (after some initial testing, Ill test it tomorrow morning) and we get input from more people. If it doesnt work, we can always revert this before publishing a new version. |
Yeah I was thinking the same thing honestly. Let me sleep on it, will make a decision tomorrow. |
jessebraham
force-pushed
the
fixes/libudev
branch
from
fbcd8fc to
03a3041
Compare
jessebraham
force-pushed
the
fixes/libudev
branch
from
03a3041 to
4c3c247
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening as draft as I guess we will need to do some testing, but at least it builds fine. We'll see what happens with HIL, I don't have a Linux box handy so that will be the first check I guess.
Not sure how we want to go about testing/verifying this.
If we merge this, closes #711. If not, we can close the issue regardless I guess.