Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove DmaChannel::set_priority #3088

Merged
merged 1 commit into from
Feb 3, 2025
Merged

Remove DmaChannel::set_priority #3088

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions esp-hal/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Removed `Pin`, `RtcPin` and `RtcPinWithResistors` implementations from `Flex` (#2938)
- OutputOpenDrain has been removed (#3029)
- The fields of config structs are no longer public (#3011)
- Removed the dysfunctional `DmaChannel::set_priority` function (#3088)

## [0.23.1] - 2025-01-15

Expand Down
9 changes: 0 additions & 9 deletions esp-hal/src/dma/gdma.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,11 +42,6 @@ impl DmaChannel for AnyGdmaChannel {
type Rx = AnyGdmaRxChannel;
type Tx = AnyGdmaTxChannel;

fn set_priority(&self, priority: DmaPriority) {
AnyGdmaRxChannel(self.0).set_priority(priority);
AnyGdmaTxChannel(self.0).set_priority(priority);
}

unsafe fn split_internal(self, _: crate::private::Internal) -> (Self::Rx, Self::Tx) {
(AnyGdmaRxChannel(self.0), AnyGdmaTxChannel(self.0))
}
Expand Down Expand Up @@ -676,10 +671,6 @@ macro_rules! impl_channel {
type Rx = AnyGdmaRxChannel;
type Tx = AnyGdmaTxChannel;

fn set_priority(&self, priority: DmaPriority) {
AnyGdmaChannel($num).set_priority(priority);
}

unsafe fn split_internal(self, _: $crate::private::Internal) -> (Self::Rx, Self::Tx) {
(AnyGdmaRxChannel($num), AnyGdmaTxChannel($num))
}
Expand Down
4 changes: 0 additions & 4 deletions esp-hal/src/dma/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1618,10 +1618,6 @@ pub trait DmaChannel: Peripheral<P = Self> {
/// A description of the TX half of a DMA Channel.
type Tx: DmaTxChannel;

/// Sets the priority of the DMA channel.
#[cfg(gdma)]
fn set_priority(&self, priority: DmaPriority);

/// Splits the DMA channel into its RX and TX halves.
#[cfg(any(esp32c6, esp32h2, esp32s3))] // TODO relax this to allow splitting on all chips
fn split(self) -> (Self::Rx, Self::Tx) {
Expand Down